Commit @075b63a743d55d46524b3f6973eb2755b87b8de2

kenu.admin 2022-12-20

clean code DIP

@075b63a743d55d46524b3f6973eb2755b87b8de2

cd6720c

075b63a

.gitignore

--- .gitignore

+++ .gitignore

...	...	@@ -3,3 +3,4 @@
3	3
4	4	## python ##
5	5	*.pyc
	6	+.scannerwork

cd6720c

075b63a

python_code/bad/DIP.py

--- python_code/bad/DIP.py

+++ python_code/bad/DIP.py


 class Worker(object):
 
     def work(self):
-        print "I'm working!!"
+        print("I'm working!!")
 
 
 class Manager(object):

         self.worker = None
 
     def set_worker(self, worker):
-        assert isinstance(worker, Worker), '`worker` must be of type {}'.format(Worker)
+        assert isinstance(
+            worker, Worker), '`worker` must be of type {}'.format(Worker)
 
         self.worker = worker
 

             self.worker.work()
             # And some complex codes go here....
 
+
 class SuperWorker(object):
 
     def work(self):
-        print "I work very hard!!!"
+        print("I work very hard!!!")
 
 # OK... now you can see what happend if we want the `Manager` to support `SuperWorker`.
 #  1. The `set_worker` must be modified or it will not pass the type-checking.
-#  2. The `manage` method should be re-test, which means you may or may not have to 
+#  2. The `manage` method should be re-test, which means you may or may not have to
 #     rewrite the testing code.
+
 
 def main():
 

     try:
         manager.set_worker(super_worker)
     except AssertionError:
-        print "manager fails to support super_worker...."
+        print("manager fails to support super_worker....")
+
 
 if __name__ == "__main__":
     main()

075b63a

sonar-project.properties (added)

+++ sonar-project.properties

...	...	@@ -0,0 +1,5 @@
	1	+sonar.projectKey=swlabs:solid
	2	+sonar.projectName=solid
	3	+sonar.sources=python_code
	4	+sonar.language=py
	5	+sonar.login=squ_a66b94df1445c77b23cd3fdb266a9ae230e0f8ec

Add a comment

Open 0
Closed 0

List

...	...	@@ -4,7 +4,7 @@
4	4	class Worker(object):
5	5
6	6	def work(self):
7		- print "I'm working!!"
	7	+ print("I'm working!!")
8	8
9	9
10	10	class Manager(object):
...	...	@@ -13,7 +13,8 @@
13	13	self.worker = None
14	14
15	15	def set_worker(self, worker):
16		- assert isinstance(worker, Worker), '`worker` must be of type {}'.format(Worker)
	16	+ assert isinstance(
	17	+ worker, Worker), '`worker` must be of type {}'.format(Worker)
17	18
18	19	self.worker = worker
19	20
...	...	@@ -22,15 +23,17 @@
22	23	self.worker.work()
23	24	# And some complex codes go here....
24	25
	26	+
25	27	class SuperWorker(object):
26	28
27	29	def work(self):
28		- print "I work very hard!!!"
	30	+ print("I work very hard!!!")
29	31
30	32	# OK... now you can see what happend if we want the `Manager` to support `SuperWorker`.
31	33	# 1. The `set_worker` must be modified or it will not pass the type-checking.
32		-# 2. The `manage` method should be re-test, which means you may or may not have to
	34	+# 2. The `manage` method should be re-test, which means you may or may not have to
33	35	# rewrite the testing code.
	36	+
34	37
35	38	def main():
36	39
...	...	@@ -44,7 +47,8 @@
44	47	try:
45	48	manager.set_worker(super_worker)
46	49	except AssertionError:
47		- print "manager fails to support super_worker...."
	50	+ print("manager fails to support super_worker....")
	51	+
48	52
49	53	if __name__ == "__main__":
50	54	main()

Delete comment