kenu / solid star
dboyliao 2015-11-25
Add SRP code.
@e96735723f9a176dba46491a18cd91a45fe18329
 
e967357
.gitignore (added)
+++ .gitignore
@@ -0,0 +1,5 @@
+## Mac ##
+.DS_Store
+
+## python ##
+*.pyc
9a828ee
 
python_code/__init__.pyc (Binary) (deleted)
--- python_code/__init__.pyc
Binary file is not shown
9a828ee
 
python_code/bad/__init__.pyc (Binary) (deleted)
--- python_code/bad/__init__.pyc
Binary file is not shown
 
e967357
python_code/bad/single_responsibility.py (added)
+++ python_code/bad/single_responsibility.py
@@ -0,0 +1,62 @@
+#!/usr/bin/env python
+# -*- coding: utf-8 -*-
+
+from abc import ABCMeta, abstractmethod
+
+class IEmail(object):
+    __metaclass__ = ABCMeta
+
+    @abstractmethod
+    def setSender(self, sender):
+        pass
+
+    @abstractmethod
+    def setReceiver(self, receiver):
+        pass
+
+    @abstractmethod
+    def setContent(self, content):
+        pass
+
+class Email(IEmail):
+
+    def __init__(self, protocol, content_type):
+        self.protocol = protocol
+        self.content_type = content_type
+        self.__sender = None
+        self.__receiver = None
+        self.__content = None
+
+    def setSender(self, sender):
+        if self.protocol == 'IM':
+            self.__sender = ''.join(["I'm ", sender])
+        else:
+            self.__sender = sender
+
+    def setReceiver(self, receiver):
+        if self.protocol == 'IM':
+            self.__receiver = ''.join(["I'm ", receiver])
+        else:
+            self.__receiver = receiver
+
+    def setContent(self, content):
+        if self.content_type == 'MyML':
+            self.__content = '\n'.join(['<myML>', content, '</myML>'])
+        else:
+            self.__content = content
+
+    def __repr__(self):
+
+        template = "Sender: {sender}\nReceiver: {receiver}\nContent:\n{content}"
+
+        return template.format(sender = self.__sender, receiver = self.__receiver, content = self.__content)
+
+def main():
+    email = Email('IM', 'MyML')
+    email.setSender('qmal')
+    email.setReceiver('james')
+    email.setContent('Hello, there!')
+    print email
+
+if __name__ == '__main__':
+    main()
 
e967357
python_code/good/single_responsibility.py (added)
+++ python_code/good/single_responsibility.py
@@ -0,0 +1,79 @@
+#!/usr/bin/env python
+# -*- coding: utf-8 -*-
+# In this implementation, it provide the same functionality as `python_code.bad.single_responsibility`.
+# There is only one reason to modify the code of `Email` if you want to support different protocol. For
+# different content, you only need to define a new subtype of `IContent`. It's not the same in the
+# implementation of `python_code.bad.single_responsibility` since there are 2 senario which you have to
+# modify the code for `Email`: different content types and different protocols.
+
+from abc import ABCMeta, abstractmethod
+
+class IEmail(object):
+    __metaclass__ = ABCMeta
+
+    @abstractmethod
+    def setSender(self, sender):
+        pass
+
+    @abstractmethod
+    def setReceiver(self, receiver):
+        pass
+
+    @abstractmethod
+    def setContent(self, content):
+        pass
+
+class IContent(object):
+    __metaclass__ = ABCMeta
+
+    @abstractmethod
+    def getString(self):
+        pass
+
+class MyContent(IContent):
+
+    def __init__(self, content):
+        self.content = content
+
+    def getString(self):
+        return "<MyML>{}</MyML>".format(self.content)
+
+class Email(IEmail):
+
+    def __init__(self, protocol):
+        self.protocol = protocol
+        self.__sender = None
+        self.__receiver = None
+        self.__content = None
+
+    def setSender(self, sender):
+        if self.protocol == 'IM':
+            self.__sender = ''.join(["I'm ", sender])
+        else:
+            self.__sender = sender
+
+    def setReceiver(self, receiver):
+        if self.protocol == 'IM':
+            self.__receiver = ''.join(["I'm ", receiver])
+        else:
+            self.__receiver = receiver
+
+    def setContent(self, content):
+        self.__content = content.getString()
+
+    def __repr__(self):
+
+        template = "Sender: {sender}\nReceiver: {receiver}\nContent:\n{content}"
+
+        return template.format(sender = self.__sender, receiver = self.__receiver, content = self.__content)
+
+def main():
+    email = Email('IM')
+    email.setSender('qmal')
+    email.setReceiver('james')
+    content = MyContent('Hello, there!')
+    email.setContent(content)
+    print email
+
+if __name__ == '__main__':
+    main()
Add a comment
List